Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default modal for new conversations reverting to Mixtral after restarting Brave #22649

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Default modal for new conversations reverting to Mixtral after restarting Brave #22649

merged 2 commits into from
Mar 18, 2024

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Mar 18, 2024 •
edited
Loading

Resolves brave/brave-browser#36886

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Oopen Leo via the Hamburger Menu and run through the onboarding/T&S
Click on Hamburger Menu -> Settings -> Leo and tap on default modal for new conversations
Pick either Claude Instant or Llama 2 13b and close the Settings page
Restart Brave and you'll notice that Mixtral is once again selected as the default model

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 18, 2024
@soner-yuksel soner-yuksel requested a review from a team March 18, 2024 13:37
@soner-yuksel soner-yuksel removed CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 18, 2024
@soner-yuksel soner-yuksel merged commit c28cf2c into master Mar 18, 2024
19 checks passed
@soner-yuksel soner-yuksel deleted the ios/bugfix/ai-chat-default branch March 18, 2024 15:50
@github-actions github-actions bot added this to the 1.66.x - Nightly milestone Mar 18, 2024
soner-yuksel added a commit that referenced this pull request Mar 18, 2024
@soner-yuksel
Merge pull request #22649 from brave/ios/bugfix/ai-chat-default
db899da
soner-yuksel added a commit that referenced this pull request Mar 18, 2024
@soner-yuksel
Merge pull request #22649 from brave/ios/bugfix/ai-chat-default
b87c79a
soner-yuksel added a commit that referenced this pull request Mar 18, 2024
@soner-yuksel
Merge pull request #22649 from brave/ios/bugfix/ai-chat-default
6fb02e3
This was referenced Mar 18, 2024
Merged
Merged
Merged
@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.66.15 Chromium: 123.0.6312.46 (Official Build) unknown (64-bit)
--- | ---
Revision | 06b2c1e3952d...
OS | iOS

Quick Note: With the following STR/Cases, it's a combination of brave/brave-browser#36816 (comment) & brave/brave-browser#36886 (comment).

Test Case #1 - Changing default Leo model within the same session - PASSED

  • ensured that switching the default Leo modal via Hamburger Menu -> Settings -> Leo retained the users selection/choice
    • also ensured that switching the Leo panel -> Advanced Settings retained the users selection/choice
  • ensured that selecting different modals via the Leo panel only changes the modal for that specific conversation/instance
RPReplay_Final1710793374.MP4

Test Case #2 - Changing default Leo model within then restarting Brave - PASSED

Using the STR/Cases outlined via brave/brave-browser#36886 (comment), ensured that restarting Brave retains the default model as per the following:

RPReplay_Final1710793653.MP4

kjozwiak pushed a commit that referenced this pull request Mar 18, 2024
@soner-yuksel
[iOS] Default modal for new conversations reverting to Mixtral after …
e6bc1c6 
…restarting Brave (uplift to 1.65.x) (#22654)

Merge pull request #22649 from brave/ios/bugfix/ai-chat-default
kjozwiak pushed a commit that referenced this pull request Mar 18, 2024
@soner-yuksel
[iOS] Default modal for new conversations reverting to Mixtral after …
17af757 
…restarting Brave (uplift to 1.64.x) (#22653)

Merge pull request #22649 from brave/ios/bugfix/ai-chat-default
kjozwiak pushed a commit that referenced this pull request Mar 18, 2024
@soner-yuksel
[iOS] Default modal for new conversations reverting to Mixtral after …
49edbf8 
…restarting Brave (uplift to 1.63.x) (#22655)

Merge pull request #22649 from brave/ios/bugfix/ai-chat-default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brandon-T Brandon-T Brandon-T approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@Brandon-T Brandon-T

@soner-yuksel soner-yuksel

Labels
None yet
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging this pull request may close these issues.

Default modal for new conversations reverting to Mixtral after restarting Brave - Follow up to #36816
4 participants
@soner-yuksel @kjozwiak @kylehickinson @Brandon-T